Skip to content

Conversation

@panva
Copy link
Member

@panva panva commented Nov 5, 2025

This changes the check for whether AKP (PQC Algorithm Key Pair JWK types) JWK import is supported to depend on the handle's prototype method presence rather than the EVP_PKEY_* IDs.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (53c4a39) to head (dd1a70b).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60586   +/-   ##
=======================================
  Coverage   88.53%   88.54%           
=======================================
  Files         704      704           
  Lines      208072   208074    +2     
  Branches    40079    40080    +1     
=======================================
+ Hits       184225   184230    +5     
+ Misses      15875    15870    -5     
- Partials     7972     7974    +2     
Files with missing lines Coverage Δ
lib/internal/crypto/keys.js 95.29% <100.00%> (+0.08%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 5, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants