Skip to content

Conversation

@Madhu696969
Copy link

This PR refines the License section in README.md for better clarity and consistency.
It clarifies that Node.js uses the MIT License, references external dependencies more clearly,
and adds a short note reminding contributors to ensure license compliance when submitting changes.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 5, 2025
@Madhu696969 Madhu696969 force-pushed the docs-label-guidance branch 2 times, most recently from 6960c86 to c242638 Compare November 5, 2025 14:05
@Madhu696969
Copy link
Author

Thanks for the review @UlisesGascon 🙏
I’ve updated the commit message format and cleaned up the Markdown spacing as per the CI checks.

@UlisesGascon
Copy link
Member

@Madhu696969 we need an additional work to make the linter happy, but almos there 👍

README.md
909:123 warning Unexpected `122` character line, expected at most `120` characters, remove `2` characters  maximum-line-length remark-lint
911:132 warning Unexpected `131` character line, expected at most `120` characters, remove `11` characters maximum-line-length remark-lint

@Madhu696969
Copy link
Author

Thanks for the feedback @UlisesGascon 🙏
I’ve addressed the remark-lint warnings by wrapping the long lines in the License section — all Markdown lines are now within the 120-character limit.

Please have a quick look when you get a chance. Appreciate your time and review! 😊

@Madhu696969
Copy link
Author

@UlisesGascon @BethGriggs
I’ve addressed the latest feedback by removing the unnecessary markdownlint disables and rewrapping lines under 120 chars.
All CI checks have passed ✅
Could you please take another quick look and re-approve when convenient? 🙏

@Madhu696969
Copy link
Author

Hi @UlisesGascon — all checks have passed and approval is completed. Could you please merge this when convenient? Thanks! 🙏

@Madhu696969
Copy link
Author

Hi @BethGriggs 👋
The PR has already been approved by @UlisesGascon and all checks have passed successfully ✅
Could you please merge it when you get a chance? Thank you for your time and review 🙏

@UlisesGascon UlisesGascon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 8, 2025
@UlisesGascon
Copy link
Member

Hey @Madhu696969! No need to keep pinging 😄

The PR looks good and has everything needed to land. Let’s give others a bit of time to review it too... it won’t get lost, don’t worry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants