disable banner #2870
Merged
disable banner #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time to take down the security banner. Don't want to leave it up too long lest people get used to not noticing it when it appears again.
nschonni
approved these changes
Jan 2, 2020
antsmartian
approved these changes
Jan 3, 2020
|
Looks like this failed to deploy similar to #2864 (comment). /ping @nodejs/build I guess? |
|
The last entries in https://nodejs.org/github-webhook.log are:
which is very old BTW we should rotate the log file more often since it becomes very big, very fast |
|
I've opened up nodejs/build#2123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to take down the security banner. Don't want to leave it up too
long lest people get used to not noticing it when it appears again.