Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: v18.20.5 release post #7221

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Blog: v18.20.5 release post #7221

merged 1 commit into from
Nov 13, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 12, 2024

Refs: nodejs/node#55768

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@aduh95 aduh95 requested a review from a team as a code owner November 12, 2024 21:53
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 12, 2024 9:55pm

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.5% (591/653) 76.06% (178/234) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
132 0 💤 0 ❌ 0 🔥 5.194s ⏱️

@mediaformat
Copy link

@aduh95 might want to fix nodejs/node#55829 before publishing a release post!

@aduh95 aduh95 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into nodejs:main with commit 24925de Nov 13, 2024
15 checks passed
@aduh95 aduh95 deleted the nodejs_18.20.5 branch November 13, 2024 01:13
bmuenzenmeyer pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants