Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove confusing close label for navigation menu #7463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 1, 2025

Description

As I was trying around navigating the website with VoiceOver, I noticed the current design is kinda confusing:

  • when the nav menu is closed, and the user focuses the checkbox, VoiceOver says "Show navigation menu, tickbox, unticked" (so far so good).
  • when the nav menu is open, and the user focuses the checkbox, VoiceOver says "Close navigation menu, tickbox, ticked", which may be kind of confusing. If the user is not able to get visual clues to know if the menu is actually currently opened, they might assume the menu is actually closed (since the checkbox is ticked).

TBH I'm not at all confident which version is the correct one, if someone who are a screen reader user could chime in, that'd be much appreciated.
An alternative would be to use a more verbose label (such as "Navigation menu is currently closed, tick the box to open it", and "Navigation menu is currently open, untick the box to close it"), not sure if this is preferable.

Validation

Related Issues

#7427

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@aduh95 aduh95 requested a review from a team as a code owner February 1, 2025 22:09
Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Feb 1, 2025 10:10pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant