-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(ui): Fix tabs component overflow issue #7798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harkunwar Kochar <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses an overflow issue in the Tabs component by adjusting its styling.
- The .tabsRoot class now applies a grid layout in addition to its maximum width property.
Comments suppressed due to low confidence (1)
packages/ui-components/Common/Tabs/index.module.css:4
- Ensure the addition of the 'grid' utility in the .tabsRoot class aligns with the intended layout behavior, and verify that the child elements are properly handled within a grid layout to avoid unintended overflow or alignment issues.
@apply grid max-w-full;
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7798 +/- ##
==========================================
+ Coverage 75.34% 75.46% +0.11%
==========================================
Files 96 101 +5
Lines 7862 8309 +447
Branches 192 218 +26
==========================================
+ Hits 5924 6270 +346
- Misses 1937 2037 +100
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Harkunwar Kochar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! And glad to see you around ✨
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@AugustinMauroy enabled the fast-track, and I approve it. |
Description
The Tabs component was overflowing on the page, causing a lot of unnecessary side effects on the page. Found this bug investigating the following issues and it should resolve both of them:
#7491
#7729
Previously:

Now:

Validation
Related Issues
#7491
#7729
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.