Skip to content

Conversation

Harkunwar
Copy link
Contributor

@Harkunwar Harkunwar commented May 31, 2025

Description

The Tabs component was overflowing on the page, causing a lot of unnecessary side effects on the page. Found this bug investigating the following issues and it should resolve both of them:
#7491
#7729

Previously:
image

Now:
image

Validation

Related Issues

#7491
#7729

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot AI review requested due to automatic review settings May 31, 2025 18:59
@Harkunwar Harkunwar requested a review from a team as a code owner May 31, 2025 18:59
Copy link

vercel bot commented May 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 31, 2025 7:05pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an overflow issue in the Tabs component by adjusting its styling.

  • The .tabsRoot class now applies a grid layout in addition to its maximum width property.
Comments suppressed due to low confidence (1)

packages/ui-components/Common/Tabs/index.module.css:4

  • Ensure the addition of the 'grid' utility in the .tabsRoot class aligns with the intended layout behavior, and verify that the child elements are properly handled within a grid layout to avoid unintended overflow or alignment issues.
@apply grid max-w-full;

Copy link

codecov bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (3ecfbcb) to head (de94b70).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7798      +/-   ##
==========================================
+ Coverage   75.34%   75.46%   +0.11%     
==========================================
  Files          96      101       +5     
  Lines        7862     8309     +447     
  Branches      192      218      +26     
==========================================
+ Hits         5924     6270     +346     
- Misses       1937     2037     +100     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Harkunwar Kochar <[email protected]>
@Harkunwar Harkunwar changed the title DRAFT: fix(Tabs): Fix tabs component overflow issue fix(ui): Fix tabs component overflow issue May 31, 2025
@Harkunwar Harkunwar enabled auto-merge May 31, 2025 19:25
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And glad to see you around ✨

Copy link
Contributor

github-actions bot commented May 31, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bjohansebas
Copy link
Member

@AugustinMauroy enabled the fast-track, and I approve it.

@Harkunwar Harkunwar added this pull request to the merge queue May 31, 2025
Merged via the queue into nodejs:main with commit df203d0 May 31, 2025
32 checks passed
@Harkunwar Harkunwar deleted the fix/tabs-component-overflow branch May 31, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breadcrumbs in the middle of the page Horizontal scroll is created on the publishing-a-package page.

6 participants