tests: add tests for injecting large resources #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
force-pushed
the
add-tests
branch
2 times, most recently
from
bacb589
to
f5acc1d
Compare
RaisinTen
force-pushed
the
add-tests
branch
from
f5acc1d
to
87437b3
Compare
RaisinTen
changed the title
RaisinTen
force-pushed
the
add-tests
branch
2 times, most recently
from
581d0ce
to
cbfc064
Compare
Fixes: #12 Signed-off-by: Darshan Sen <[email protected]>
RaisinTen
force-pushed
the
add-tests
branch
from
cbfc064
to
5d90d49
Compare
robertgzr
reviewed
Sep 20, 2022
| cc test.c -o "$bin" | ||
|
|
||
| input="$TEMPORARY_DIRECTORY/input.txt" | ||
| head -c 1073741824 /dev/urandom > "$input" |
There was a problem hiding this comment.
why not head -c 1G /dev/urandom?
There was a problem hiding this comment.
@robertgzr doesn't work on macOS unfortunately
RaisinTen
force-pushed
the
add-tests
branch
from
5d90d49
to
fd5855c
Compare
RaisinTen
added a commit
that referenced
this pull request
Sep 20, 2022
Addresses #7 (comment). Signed-off-by: Darshan Sen <[email protected]>
RaisinTen
added a commit
that referenced
this pull request
Sep 20, 2022
Addresses #7 (comment). Signed-off-by: Darshan Sen <[email protected]>
dsanders11
requested changes
Sep 21, 2022
There was a problem hiding this comment.
I think we should hold off on landing changes to tests until #8 lands, it changes how tests are implemented.
Can we focus that PR on just the WASM-related changes instead? I don't think it's a good idea to mix unrelated things into a PR if we can help it because as we can see here, it's blocking the progress of other PRs. Feel free to let me know if you're stuck anywhere because I've noticed that the last push was 11 days ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12
Signed-off-by: Darshan Sen [email protected]