Skip to content

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 21, 2025

Now the order of operations is comparable to CloseEvent and MessageEvent

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@Uzlopak Uzlopak requested a review from KhafraDev August 21, 2025 14:02
Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix anything. If it does fix something, we need a test.

@Uzlopak Uzlopak requested a review from Copilot September 6, 2025 09:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This fix reorders operations in the ErrorEvent constructor to ensure arguments are converted before being passed to the parent constructor, making the implementation consistent with CloseEvent and MessageEvent constructors.

  • Moved argument conversion (webidl.converters calls) to occur before the super() call
  • Repositioned the webidl.util.markAsUncloneable() call after super() constructor execution

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants