perf: use less promises in extractBody #4458
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See my answer to your linked comment. |
There was a problem hiding this comment.
Pull Request Overview
This PR improves performance in the extractBody function by reducing the use of async/await syntax in favor of explicit promise handling.
- Removes async/await from ReadableStream controller methods
- Converts async functions to return promises directly using
.then() - Simplifies promise handling in iterator operations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| async cancel (reason) { | ||
| await iterator.return() | ||
| cancel (reason) { | ||
| return iterator.return() |
There was a problem hiding this comment.
The iterator.return() call may not exist on all iterators, as it's an optional method in the async iterator protocol. This could cause a runtime error if the iterator doesn't implement the return method. Consider checking if the method exists before calling it: return iterator.return?.() || Promise.resolve().
Suggested change
| return iterator.return() | |
| return iterator.return?.() || Promise.resolve() |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status