Skip to content

feat(http-classes-with-new): add codemod for node:http classes instantiation with new keyword #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 3, 2025
Merged

feat(http-classes-with-new): add codemod for node:http classes instantiation with new keyword #179

merged 12 commits into from
Sep 3, 2025

Conversation

max-programming
Copy link
Contributor

Closes #174

AugustinMauroy
AugustinMauroy reviewed Aug 13, 2025
View reviewed changes
AugustinMauroy
AugustinMauroy reviewed Aug 13, 2025
View reviewed changes
AugustinMauroy
AugustinMauroy reviewed Aug 13, 2025
View reviewed changes
AugustinMauroy
AugustinMauroy approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! Thanks for your contribution

avivkeller
avivkeller approved these changes Aug 14, 2025
View reviewed changes
brunocroh
brunocroh reviewed Aug 14, 2025
View reviewed changes
@max-programming
Copy link
Contributor Author

@AugustinMauroy this can be merged now i guess

@AugustinMauroy
Copy link
Member

@AugustinMauroy this can be merged now i guess

I would like to have @JakobJingleheimer which is the maintainer of this repo. But without violating our collaboration policy, I could merge, but I still prefer to wait for his approval.

@max-programming
Copy link
Contributor Author

Makes sense. It's fine we'll wait

@JakobJingleheimer
Copy link
Member

I'll do today

PS Sorry I'm on holiday until 10 Sep.

JakobJingleheimer
JakobJingleheimer approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple 🙌

Some small things that could be addressed before release, but nothing blocking.

@JakobJingleheimer JakobJingleheimer merged commit 8ab386f into nodejs:main Sep 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@brunocroh brunocroh brunocroh approved these changes

@avivkeller avivkeller avivkeller approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: handle DEP0195: Instantiating node:http classes without new
5 participants
@max-programming @AugustinMauroy @JakobJingleheimer @brunocroh @avivkeller