Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtctime: try harder to speak in integers #3161

Merged
merged 1 commit into from
Jun 20, 2020
Merged

rtctime: try harder to speak in integers #3161

merged 1 commit into from
Jun 20, 2020

Conversation

nwf
Copy link
Member

@nwf nwf commented Jun 13, 2020

Otherwise we might truncate precision with small floats and that's
unlikely to work out well for anyone.

Found by testing #2819 against Lua 5.3.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

@nwf
rtctime: try harder to speak in integers
dadcd3f 
Otherwise we might truncate precision with small floats and that's
unlikely to work out well for anyone.
@nwf nwf requested a review from pjsg June 13, 2020 05:04
@marcelstoer marcelstoer added this to the Next release milestone Jun 13, 2020
@marcelstoer marcelstoer merged commit 90beedf into nodemcu:dev Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjsg pjsg Awaiting requested review from pjsg

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
September 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@nwf @marcelstoer