Skip to content

Upgrading mongoose version to 8.x#238

Merged
pacostas merged 7 commits intonodeshift:mainfrom
pacostas:upgrading-mongoose
Sep 4, 2024
Merged

Upgrading mongoose version to 8.x#238
pacostas merged 7 commits intonodeshift:mainfrom
pacostas:upgrading-mongoose

Conversation

@pacostas
Copy link
Copy Markdown
Member

@pacostas pacostas commented Sep 3, 2024

This PR :

  • converts mongoose callbacks to async await.
  • adds an extra variable to disable replicaSet in local setup
  • Adds node version 22 to test against
  • upgrading actions to v4 (as there are warnings)
  • Commenting out pkgjs/support step on github workflows

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 3, 2024

Pull Request Test Coverage Report for Build 10683395574

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+35.1%) to 35.088%

Totals Coverage Status
Change from base Build 10417327706: 35.1%
Covered Lines: 20
Relevant Lines: 51

💛 - Coveralls

@pacostas
Copy link
Copy Markdown
Member Author

pacostas commented Sep 3, 2024

@mhdawson @lholmquist

I've disable the npx @pkgjs/support show step as it breaks due to unsopported node engine.

Opened Issue pkgjs/support#52

@pacostas pacostas requested a review from lholmquist September 3, 2024 16:11
Copy link
Copy Markdown
Contributor

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacostas pacostas merged commit 8006f7b into nodeshift:main Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants