-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v22.x] Backports for new release #225
Open
santigimeno
wants to merge
13
commits into
node-v22.x-nsolid-v5.x
Choose a base branch
from
santi/backport_to_22
base: node-v22.x-nsolid-v5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #213 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #214 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #215 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #217 Reviewed-By: Trevor Norris <[email protected]>
Don't look for the last element but the third. PR-URL: #218 Reviewed-By: Trevor Norris <[email protected]>
Also, a couple of fixes in the updater. PR-URL: #219 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #220 Reviewed-By: Trevor Norris <[email protected]>
A couple of fixes here: - Both the `uv_mutex_t` and `uv_cond_t` should be initialized before defining the lambda. - Add a boolean variable to make sure we're not waiting forever in the case the lambda code is run before reaching the `uv_cond_wait()`. PR-URL: #222 Reviewed-By: Trevor Norris <[email protected]>
It should also cover the `start_profiling` fn execution. PR-URL: #222 Reviewed-By: Trevor Norris <[email protected]>
Increase the timeouts a bit to make sure the heapSampling and the cpuProfile are actually stopped before trying to start a new one. PR-URL: #222 Reviewed-By: Trevor Norris <[email protected]>
Commit picked from protocolbuffers/protobuf@6469795 PR-URL: #222 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #223 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #179 Fixes: #178 Reviewed-By: Trevor Norris <[email protected]>
juanarbol
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the commit list, lgmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.