Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.x] Backports for new release #225

Open
wants to merge 13 commits into
base: node-v22.x-nsolid-v5.x
Choose a base branch
from

Conversation

santigimeno
Copy link
Member

No description provided.

PR-URL: #213
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #217
Reviewed-By: Trevor Norris <[email protected]>
Don't look for the last element but the third.

PR-URL: #218
Reviewed-By: Trevor Norris <[email protected]>
Also, a couple of fixes in the updater.

PR-URL: #219
Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #220
Reviewed-By: Trevor Norris <[email protected]>
A couple of fixes here:
- Both the `uv_mutex_t` and `uv_cond_t` should be initialized before
  defining the lambda.
- Add a boolean variable to make sure we're not waiting forever in the
  case the lambda code is run before reaching the `uv_cond_wait()`.

PR-URL: #222
Reviewed-By: Trevor Norris <[email protected]>
It should also cover the `start_profiling` fn execution.

PR-URL: #222
Reviewed-By: Trevor Norris <[email protected]>
Increase the timeouts a bit to make sure the heapSampling and the
cpuProfile are actually stopped before trying to start a new one.

PR-URL: #222
Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #223
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #179
Fixes: #178
Reviewed-By: Trevor Norris <[email protected]>
@santigimeno santigimeno self-assigned this Nov 21, 2024
Copy link
Contributor

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the commit list, lgmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants