chore: adding workflow to add issues to docs on docs needed label#1178
Merged
TomAFrench merged 8 commits intomasterfrom Apr 24, 2023
Merged
chore: adding workflow to add issues to docs on docs needed label#1178TomAFrench merged 8 commits intomasterfrom
TomAFrench merged 8 commits intomasterfrom
Conversation
Member
|
Can you trim out the generic comments from the workflows? They're adding noise to the files. We could also merge these two workflows into one. |
Contributor
Author
|
done @TomAFrench |
TomAFrench
requested changes
Apr 19, 2023
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
We don't need two copies of the dispatch_open and dispatch_close job afaict. We only need to change the workflow id between them so we should just need an "if-else" on that argument.
Contributor
Author
|
thanks @TomAFrench just did that 👍 |
phated
reviewed
Apr 19, 2023
phated
reviewed
Apr 19, 2023
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Contributor
|
Leaving this to @phated as I don't know enough about the CI |
phated
reviewed
Apr 20, 2023
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Contributor
Author
|
@TomAFrench can you review this so it gets merged? |
TomAFrench
previously approved these changes
Apr 21, 2023
Member
|
Actually, @signorecello could we merge the workflows that this workflow will be triggering first before we merge this? Not sure how GH will react to a missing workflow. |
Member
|
Holding off for a little bit due to #1193 (comment) |
kevaundray
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
It creates a new workflow that automatically creates new issues in the docs repo when someone assigns the "doc needed" label here
Checklist
cargo fmtwith default settings.