feat: experimental acir optimisation #6341
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Related to #6085
Summary*
This PR is an attempt to perform the 'as_witness' automatically.
The idea is to create witness for each common expression, instead of having the user to specify the expressions to fit into a witness. Because this strategy generates a lot of 'small' arithmetic opcodes, I benefit from the big-add-gate (cf. #6085) by simplifying those small opcodes into the ones which use them.
Additional Context
In general this optimisation works well, but some corner cases still need to be investigated. Indeed, the simplification may generate too many opcodes which do not fit the width.
Hence, it is hidden by a non-documented compiler option (experimental-optimisation).
I leave it as a draft for now.
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.