feat: error if generic type parameter in impl is not mentioned in self type #6388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #5855
Summary
I decided to do this check separately... that is, another way could have been to keep track of which generics we saw while we solve
self_type
, but I think that would lead to code that's harder to understand. I was also able to use the visitor pattern to quickly find the mentioned generic types (I had to update Visitor so that it correctly traverses unresolved type expressions).Additional Context
Some questions:
impl
... do we also want to do it for trait impls? If yes, in this PR or a separate one?Documentation
Check one:
PR Checklist
cargo fmt
on default settings.