Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix: check pending learner before promote in rule checker #18

Open
wants to merge 30 commits into
base: enable-placementrule
Choose a base branch
from
Open

bug fix: check pending learner before promote in rule checker #18

wants to merge 30 commits into from

Conversation

ZenoTan
Copy link

@ZenoTan ZenoTan commented Oct 10, 2020

Signed-off-by: ZenoTan [email protected]

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

HunDunDM and others added 16 commits September 25, 2020 16:07
@HunDunDM
client: rename GetMemberInfo to GetAllMembers (tikv#3029)
6d0aa71 
Signed-off-by: jyz0309 <[email protected]>
@JmPotato
tso: use sync.RWMutex to control concurrent reading and writing (tikv…
0e9a678 
…#3016)

Signed-off-by: JmPotato <[email protected]>
@JmPotato
tso: add SyncMaxTS RPC method (tikv#2988)
427dd4c 
Signed-off-by: JmPotato <[email protected]>
@JmPotato
tools: enhance the pd-tso-bench (tikv#3032)
adc0dd8 
Signed-off-by: JmPotato <[email protected]>
@lizhemingi
pdctl: add state filter support in store command (tikv#3018)
458b7ae 
* pdctl: add state filter support in store command

Signed-off-by: Zheming Li <[email protected]>
@rleungx
api: add check learner-peer API (tikv#3036)
177f8f8 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
api: reduce duplicated functions (tikv#3040)
84dde98 
Signed-off-by: Ryan Leung <[email protected]>
@Yisaer
config: unify the redact log configuration with tikv (tikv#3037)
7661eae 
Signed-off-by: Song Gao <[email protected]>
@rleungx
cluster: check if region is valid before handling it (tikv#3041)
4199e72 
Signed-off-by: Ryan Leung <[email protected]>
@Yisaer
scheduler: support regions relocating by range (tikv#3028)
a5d1b1e 
Signed-off-by: Song Gao <[email protected]>
@disksing
server: move heartbeat test to heartbeat package (tikv#3010)
a4ab63c 
Signed-off-by: disksing <[email protected]>
@JmPotato
tso: add election priority for Local TSO Allocator (tikv#2953)
43baea9 
Signed-off-by: JmPotato <[email protected]>
@longfangsong
scheduler: Add auto-gc for Region Scatter (tikv#3038)
9ed9111 
Signed-off-by: longfangsong <[email protected]>
@lhy1024
metrics: add heartbeat interval and distribution of region bytes, key…
f0b0d97 
…s metrics (tikv#3031)

Signed-off-by: lhy1024 <[email protected]>
@MyonKeminta
tso: Support configuring tso update physical interval (tikv#3027)
90a934a 
Signed-off-by: MyonKeminta <[email protected]>
@rleungx
api: add status query parameter for the scheduler API (tikv#3055)
858ef8c 
Signed-off-by: Ryan Leung <[email protected]>
nolouch
nolouch reviewed Oct 10, 2020
View reviewed changes
Copy link
Owner

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

server/schedule/operator/create_operator.go Outdated
@@ -34,6 +34,9 @@ func CreateAddPeerOperator(desc string, cluster opt.Cluster, region *core.Region

// CreatePromoteLearnerOperator creates an operator that promotes a learner.
func CreatePromoteLearnerOperator(desc string, cluster opt.Cluster, region *core.RegionInfo, peer *metapb.Peer) (*Operator, error) {
if region.GetPendingPeer(peer.GetId()) != nil {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is more reasonable in the builder.

nolouch pushed a commit that referenced this pull request Dec 30, 2022
@zeminzhou
Merge pull request #18 from tidbcloud/add-approixmatekvsize
756d4a0 
server: Add `approixmateKvSize` fro `RegionInfo` to use for TiDB ratelimit
nolouch pushed a commit that referenced this pull request Feb 24, 2023
@disksing
6.6: add approixmate kv size (#18) (tikv#26)
f76b7b2 
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: disksing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.