feat(sing): order "Your songs tonight" by queue position + clear sung songs (v0.88.0) - #201
Merged
Merged
Conversation
… songs (v0.88.0) The singer done screen rendered songs in submission order and never removed sung ones, so a reordered queue looked wrong and the list grew all night. - backend /my-requests: add per-song `performed` flag (derived from the linked rotation entry being Done/Left); drop the stale estimate for performed songs. - frontend: sort the active list into sung order (now singing → queue position → awaiting KJ); move performed songs into a collapsed "✓ Already sung tonight (N)" section (read-only); exclude performed songs from the "My songs" bar count + boot-restore. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
beveradb
force-pushed
the
feat/sess-20260717-0213-singer-songs-tonight-ux
branch
from
July 17, 2026 16:12
7a54f11 to
12167fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to the singer-facing "Your songs tonight" done screen (
sing.nomadkaraoke.com):sing_requeststaysapprovedafter its rotation entry is sung, so sung songs lingered (as a misleading "Added to the queue") and the list grew all night. Sung songs now move into a collapsed "✓ Already sung tonight (N)" section.Changes
sing.py/my-requests): add a per-songperformedflag, derived from the linked rotation entry being Done/Left (targetedget_entrylookup for ids not in the active queue); no stale estimate attached for performed songs.sing.js):_splitAndSortSongs+_activeSortKeysort the active list;_renderSungSectionrenders the collapsed read-only history (open/closed state preserved across the 15s poll); performed songs are read-only (no cancel/change/reorder);_liveSongsexcludes performed so the "🎤 My songs (N)" bar count and boot smart-restore ignore sung songs (a singer who's finished lands on the request screen, not a stale list).sing.css): style the collapsed sung section.docs/ARCHITECTURE.md): document the new response shape + behavior.Testing
performedflag on a Done entry) + 4 new Playwright e2e tests (queue-order sort, sung-song collapse, read-only sung cards, no-section-when-none)systemctlaudio test); verified they also fail on the stashed pre-change treeReview
/code-reviewfallback: no correctness bugs; only low-severity cosmetic/efficiency notes, none warranting a change@coderabbitai ignore
🤖 Generated with Claude Code