fix: use /en/quiz locale prefix in decide health checks - #10
Merged
Conversation
Production decide.nomadkaraoke.com is a Next.js static export, so the
next-intl locale middleware never runs and bare /quiz returns 404.
Direct page.goto("/quiz") in the e2e specs was failing 3x with retries
and tripping the scheduled health check. Homepage flows still worked
because the Link components are locale-aware.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decide Health Checkworkflow was failing on the test "quiz page loads with genre selection" — failed run #26064397324.decide.nomadkaraoke.comis a Next.js static export, so the next-intl middleware never runs.page.goto("/quiz")hits the static 404 page; only/en/quiz(locale-prefixed) is generated. Locale-awareLinkclicks on the homepage still worked, which is why only the direct-navigation tests broke.page.goto("/quiz")calls ine2e/health-check.spec.tsande2e/onboarding-comprehensive.spec.tsto/en/quiz.Verification
npx playwright test e2e/health-check.spec.ts --project=chromium→ 9/9 pass (previously 1 failed, 3 did not run).npx playwright test e2e/onboarding-comprehensive.spec.ts --project=chromium→ 2/2 pass.Out of scope (follow-up)
The same failed run also logged
Mail command failed: 501 5.1.7 Bad sender address syntaxfrom the Postmark notification step (introduced in #9). That's a separate bug worth tracking — Postmark likely needs a verified sender signature foradmin@nomadkaraoke.com, or thefrom:value needs to be reformatted.@coderabbitai ignore
🤖 Generated with Claude Code