Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for remote model templates when messages contain xml. #3318

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Fix for remote model templates when messages contain xml. #3318

merged 4 commits into from
Dec 18, 2024
+10 −5

Conversation

manyoso
Copy link
Collaborator

@manyoso manyoso commented Dec 18, 2024

No description provided.

@manyoso manyoso requested a review from cebtenzzre December 18, 2024 15:35
cebtenzzre
cebtenzzre requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@cebtenzzre cebtenzzre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will still break if the chat message contains ]]>. Jinja's original purpose was to generate XML and HTML, this is why it has the e/escape filter which escapes text for output in XML. e.g. {{- message.content | e }}

@manyoso @cebtenzzre
Update gpt4all-chat/src/modellist.cpp
6907978 
Co-authored-by: Jared Van Bortel <[email protected]>
Signed-off-by: AT <[email protected]>
@manyoso manyoso merged commit 5ab70da into main Dec 18, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebtenzzre cebtenzzre cebtenzzre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manyoso @cebtenzzre