This repository was archived by the owner on Mar 4, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added QuickCheck tests for IntMap (didn't have time for more)
Important change in need of approval, we added
deriving Eq
toData.UnionFind.IntMap.Point
. The only other way to compare the descriptors of the points in the current implementation is to compare descriptors. As it is, only the representative point keep the descriptor, so it is not a very direct means of comparing (but it would possibly turn out correct anyway). A user of the library might also want to be able to compare Points, however, the users shouldn't confuse==
with the functionequivalence
.Description solution:
cabal test
and itself reference the quickCheck property tests.We are two students (@dfurian) enrolled in a advanced functional programming course. We were told to contribute to an open source project and ended up here :) Unfortunately we did not have time to test the whole library, but hope it can be of any use.