Fix text rendering, update dependencies for new purescript #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh and thank you for creating this! Saved me a lot of trouble trying to embed the svgs myself |
|
Hi, thanks for your pull request. Do you mind reverting the changes introduced by purty? I haven't tried purty yet. I'm more familiar with the old formatting, and will work on #1 some time, which may introduce some inconsistency with purty formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to use this to convert Streamline icons recently and had a couple stumbling blocks. Fixed the text node rendering to wrap stuff in quotes, and updated dependencies so the project builds with latest purescript. I have
purtyinstalled so it looks like a lot of changes in Render.purs but the only real change is: