Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for daemon-mode Emacs. #68

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

somesoup
Copy link

Modify the check for display-graphic-p to include daemonp so that colors get defined even when no frames are open in a display manager.

@rien333
Copy link
Contributor

rien333 commented Dec 19, 2019

@somesoup any idea if this still works?

@jakobwinkler
Copy link

For my setup this is still working (and required to get emacsclient to open). I'd be very happy if this could be merged.

@ssnnoo
Copy link

ssnnoo commented Jan 2, 2021

Does anyone know if this will go in at some point? Though there are not conflicts...

@EdwardIII
Copy link

EdwardIII commented Oct 18, 2022

Hey @somesoup looks like there are conflicts now, maybe you could do a rebase to make it more of a no-brainer for @arcticicestudio to review?

Edit: Actually having looked a bit deeper this might cause problems, as daemonp doesn't necessarily mean high colour mode. Someone could use the daemon but still start their client in the console. So maybe time to close this off?

Demo of what happens to console if you do use this technique:

image

@svengreb svengreb self-requested a review as a code owner March 11, 2023 11:31
@svengreb svengreb force-pushed the develop branch 3 times, most recently from aa83e0d to 5335a7e Compare April 10, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants