Skip to content

fix format string in build.rs #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
noritada merged 1 commit into from
May 17, 2025
Merged

fix format string in build.rs #115

noritada merged 1 commit into from
May 17, 2025

Conversation

@ejd
Copy link
Contributor

@ejd ejd commented Apr 29, 2025

Fixes a clippy::uninlined-format-args detected in build.rs

@ejd
fix format string in build.rs
5d68063 
Fixes a `clippy::uninlined-format-args` detected in `build.rs`
@ejd
Copy link
Contributor Author

ejd commented Apr 29, 2025 •
edited
Loading

A recent nightly version of Rust added the dangerous_implicit_autorefs lint. After making the change for this PR, I ran cargo +nightly clippy --workspace per the contribution guide. clippy flagged two lines in src/decoder/jpeg2000/ext.rs for the dangerous_implicit_autorefs lint. Despite the fix included in this PR, CI will still fail because clippy warnings are turned into errors in CI.

I'm assuming the code in src/decoder/jpeg2000/ext.rs is based in part on the the jpeg2k crate's stream module. If that's the case, it may be worth looking at their implementation of WrappedStream. When I run cargo +nightly clippy against the jpeg2k crate, it does not appear to trigger the new dangerous_implicit_autorefs lint. I'd be going out of my depth with Rust to suggest why their implementation avoids the lint though.

For what it's worth, I'm using rustc 1.88.0-nightly (25cdf1f67 2025-04-28).

@ejd ejd mentioned this pull request May 7, 2025
Merged
noritada
noritada approved these changes May 17, 2025
View reviewed changes
Copy link
Owner

@noritada noritada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late reply.
Thank you so much!

I am aware of CI failures due to remaining lint errors.

@noritada noritada merged commit d35dfdd into noritada:master May 17, 2025
9 of 10 checks passed
noritada added a commit that referenced this pull request May 17, 2025
@noritada
Merge pull request #116 from ejd/update-proj-to-0.30
3de61fa 
update proj to 0.30

This MR updates proj to 0.30.

The project I'm working on that uses `grib-rs` already enables `proj/bundled_proj`.  I would also like to take advantage of the fact that the newest `proj-sys` uses `libsqlite3-sys` which provides a similar `bundled` feature.

All tests passed when I ran `cargo test --workspace`.

I ran `cargo +nightly clippy --workspace` per the contribution guide.  The version I'm using, `clippy 0.1.88 (25cdf1f674 2025-04-28)`, identifies unrelated code issues that I mentioned over on #115.
@ejd ejd deleted the fix-failed-ci branch May 19, 2025 14:15
@ejd
Copy link
Contributor Author

ejd commented May 19, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noritada noritada noritada approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ejd @noritada