Skip to content

Initial migration to xterm.js #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: replace-fix
Choose a base branch
from
Open

Initial migration to xterm.js #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/build-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default class BuildView extends View {
}

constructor(...args) {
const Terminal = require('term.js');
const Terminal = require('xterm');
super(...args);
this.starttime = new Date();
this.terminal = new Terminal({
Expand All @@ -51,7 +51,7 @@ export default class BuildView extends View {
this.fontGeometry = { w: 15, h: 15 };
this.terminal.open(this.output[0]);
this.destroyTerminal = ::(this.terminal).destroy;
this.terminal.destroy = this.terminal.destroySoon = () => {}; // This terminal will be open forever and reset when necessary
this.terminal.destroy = () => {}; // This terminal will be open forever and reset when necessary
this.terminalEl = $(this.terminal.element);
this.terminalEl[0].terminal = this.terminal; // For testing purposes

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"getmac": "^1.0.7",
"js-yaml": "^3.4.6",
"node-uuid": "^1.4.3",
"term.js": "git+https://github.com/jeremyramin/term.js.git#de1635fc2695e7d8165012d3b1d007d7ce60eea2",
"xterm":"^0.32.0",
"tree-kill": "^1.0.0",
"xregexp": "^3.1.0"
},
Expand Down
10 changes: 10 additions & 0 deletions styles/build.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
@import "ui-variables";
@import "animations";
@import "node_modules/xterm/src/xterm.css";

.build {

Expand Down Expand Up @@ -107,3 +108,12 @@
color: @text-color-error;
}
}

.terminal .xterm-helper-textarea {
display: none;
// text-indent: -9999em;
// opacity: 0;
// width: 0;
// height: 0;
// z-index: -10;
}