Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the decimal was just being dropped, causing the values of get_fps() to always oscillate between 59 and 60, for example. This isn't very helpful when debugging, and it's due to the decimal being cut off even if it's, let's say, 59.9 due to floating point arithmetic.
Now the value is rounded, which is more helpful when monitoring for massive frame drops.
Alternatively, if desired, we could change this to be a float that includes some number of decimal places and can be rounded/cast as desired by the developer calling the function. We could also keep track of many frames of data and average it out. But at least this is a bit more usable for now.
Before
macroquad.fps.old.mov
notice it rapidly changing
after
macroquad.fps.new.mov
notice it'll occasionally drop a frame (unsure why)
Code