Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace slotmap dependency with reduced local version #794

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Sep 5, 2024

This showed a slight improvement in compile time for me, as slotmap is only used in texture.rs and most of it is not needed and many things can be simplified based on the limited use case.

@not-fl3
Copy link
Owner

not-fl3 commented Sep 5, 2024

Thanks, great work! Yeah, the whole slotmap deal was a big mistake, but with your fix we at least will not pay for it with compile time.

@not-fl3 not-fl3 merged commit 2af0393 into not-fl3:master Sep 5, 2024
6 checks passed
@cyrgani cyrgani deleted the slotmap-removal branch September 5, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants