make all Rect methods const, fix a small bug in Rect::contains#919
Merged
not-fl3 merged 1 commit intonot-fl3:masterfrom Mar 23, 2025
Merged
make all Rect methods const, fix a small bug in Rect::contains#919not-fl3 merged 1 commit intonot-fl3:masterfrom
Rect methods const, fix a small bug in Rect::contains#919not-fl3 merged 1 commit intonot-fl3:masterfrom
Conversation
…ing points on the border
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to rust-lang/rust#129195, all methods on
Rectcan become const now, including those with&mut self.Also fixes a small bug where points on the border of a rect where not recognized to be in it, and adds a simple test for that.