Skip to content

Commit

Permalink
sound: fix ym2612 freq latch
Browse files Browse the repository at this point in the history
there is only a single register, as described in:
http://www.mjsstuf.x10host.com/pages/vgmPlay/vgmPlay.htm
  • Loading branch information
notaz committed Jan 12, 2024
1 parent ca980e1 commit 7a4081a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 3 additions & 3 deletions pico/sound/ym2612.c
Original file line number Diff line number Diff line change
Expand Up @@ -1671,8 +1671,8 @@ static int OPNWriteReg(int r, int v)
switch( OPN_SLOT(r) ){
case 0: /* 0xa0-0xa2 : FNUM1 | depends on fn_h (below) */
{
UINT32 fn = (((UINT32)( (CH->fn_h)&7))<<8) + v;
UINT8 blk = CH->fn_h>>3;
UINT32 fn = ((UINT32)(ym2612.OPN.ST.fn_h & 7) << 8) | v;
UINT8 blk = ym2612.OPN.ST.fn_h >> 3;
/* keyscale code */
CH->kcode = (blk<<2) | opn_fktable[fn >> 7];
/* phase increment counter */
Expand All @@ -1685,7 +1685,7 @@ static int OPNWriteReg(int r, int v)
}
break;
case 1: /* 0xa4-0xa6 : FNUM2,BLK */
CH->fn_h = v&0x3f;
ym2612.OPN.ST.fn_h = v & 0x3f;
ret = 0;
break;
case 2: /* 0xa8-0xaa : 3CH FNUM1 */
Expand Down
5 changes: 3 additions & 2 deletions pico/sound/ym2612.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ typedef struct
UINT8 ams; /* channel AMS */

UINT8 kcode; /* +11 key code: */
UINT8 fn_h; /* freq latch */
UINT8 pad2;
UINT8 upd_cnt; /* eg update counter */
UINT32 fc; /* fnum,blk:adjusted to sample rate */
UINT32 block_fnum; /* current blk/fnum value for this slot (can be different betweeen slots of one channel in 3slot mode) */
Expand All @@ -101,7 +101,8 @@ typedef struct
int TAC; /* timer a maxval */
int TAT; /* timer a ticker | need_save */
UINT8 TB; /* timer b */
UINT8 pad2[3];
UINT8 fn_h; /* freq latch */
UINT8 pad2[2];
int TBC; /* timer b maxval */
int TBT; /* timer b ticker | need_save */
/* local time tables */
Expand Down

0 comments on commit 7a4081a

Please sign in to comment.