Skip to content

Allow for dynamic view switching#50

Open
Yahiewi wants to merge 1 commit into
notebook-link:mainfrom
Yahiewi:view-bug
Open

Allow for dynamic view switching#50
Yahiewi wants to merge 1 commit into
notebook-link:mainfrom
Yahiewi:view-bug

Conversation

@Yahiewi

@Yahiewi Yahiewi commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

This addresses issue #47 by using a local layout tracker for each tab _currentLayoutName, instead of a global one.
This allows users to have multiple tabs with different specta views open simultaneously and switch between them.

Screencast.from.2026-06-01.19-33-32.mp4

@trungleduc trungleduc self-requested a review June 3, 2026 12:51
@trungleduc

Copy link
Copy Markdown
Collaborator

@Yahiewi could you put your CI fix line here? I want to get this one and #44 in

@Yahiewi

Yahiewi commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

Hey @trungleduc I've been struggling with the CI for this and I'm not sure what the issue is exactly. It seems to be failing at the environment resolution step but I have no idea why that's failing now. I'm not sure if some of the dependencies were migrated or changed. Do you have an idea maybe on what's breaking this?
BTW, I'm getting the exact same issue for these two other PRs:
Jupyter-plainb PR
Specta PR

@trungleduc

Copy link
Copy Markdown
Collaborator

could you try switching the channel here to emscripten-forge-4x?

@trungleduc

Copy link
Copy Markdown
Collaborator

@Yahiewi please rebase to get the CI fixed

@Yahiewi

Yahiewi commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks a lot @trungleduc CI is green now. Hopefully this will also fix the CI for the other PRs.

@trungleduc

Copy link
Copy Markdown
Collaborator

Does this mean we re-render the view on each jupyterlab tab change if the layout is different between 2 tabs?

Comment thread src/specta_widget.ts
super.onCloseRequest(msg);
}

private _onSelectedLayoutChanged(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I removed the layout switch option because rerendering the view with a different layout on the fly is bugged. Could you double-check this on both Jupyter and the standalone app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants