Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update README.md #69

wants to merge 2 commits into from

Conversation

DizzyG123
Copy link

Added to music theory pages; trying to find out how to properly do a pull request

Added to music theory pages; trying to find out how to properly do a pull request
@levinericzimmermann
Copy link
Collaborator

Thanks @kvitor123.

Unfortunately there is a space too much between the square bracket and the round bracket, it should be [Music Theory for Musicians](https://www.music-theory-for-musicians.com/) instead of [Music Theory for Musicians] (https://www.music-theory-for-musicians.com/). With this space, the markdown code isn't correctly rendered as a link.

Once this is corrected, this looks fine to me.

Corrected spacing
@DizzyG123
Copy link
Author

@levinericzimmermann Fixed the spacing. Can the code be rendered as a link now? Let me know if it doesn't work still.

@levinericzimmermann
Copy link
Collaborator

Thanks @kvitor123, it works now! Maybe just please squash your commits into one, as this is semantically only 1 change ("Add Music Theory for Musicians").

@DizzyG123
Copy link
Author

Hey there,

Thanks for letting me know. If this is good to go, does someone review it and approve whether or not it gets added in the main page? I was looking back at it and noticed that the website wasn't there. It could be because I'm not looking in the right place for the change, but just wanted to ask if I could know for future commits.

@noteflakes
Copy link
Owner

Hi, please put the new entry in the correct place in order to respect alphabetic ordering.

@DizzyG123
Copy link
Author

Okay @noteflakes I can look into it today to put it in the correct place. Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants