Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat. Add Tweet Embed Component #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat. Add Tweet Embed Component #95

wants to merge 1 commit into from

Conversation

myjeong19
Copy link
Member

Description of Changes

Here is reference: #25


support 'tweet' block

  • add custom solution for rendering 'tweet block': Added a custom solution to automatically adjust the height of the tweet embed component and remove the scrollbar.

Review point

  • Should we integrate an existing solution or use a custom implementation for 'tweet block'?: Discussion is needed on whether to integrate an existing solution or use a custom implementation tailored to the project.

To reproduce

  • npm run story:start
  • Click on 'tweet block' in the Storybook left side panel

Screenshot

Screenshot 2025-03-25 at 06 35 29

  • A screenshot of your created block being rendered in Storybook.

Review Guide

Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant