Skip to content
This repository was archived by the owner on Dec 12, 2021. It is now read-only.

Conversation

@Gregory-Pereira
Copy link

@Gregory-Pereira Gregory-Pereira commented Feb 11, 2021

What is the story, issue or feature this Pull Request is solving or implementing?

Working on issue #144

What is the approach you are using to solve the issue above?

updated the contents of the /src/components/common/header/header.scss, pulled styling from src/components/home/sections/welcome.scss

What are the changes that this Pull Request is introducing?

  1. Keep the border of the button purple
  2. Make the button background color white.
  3. Make the button text either purple or black.

Is there something this Pull Request is dependent on before it can be merged in?

Not to my knowledge

Completeness Checklist

  • Local Tests are passing.
  • New tests have been added for new code where relevant
  • Screenshots of before and after changes have been added

Before:
Screen Shot 2021-02-11 at 11 50 26 AM

After:
Screen Shot 2021-02-11 at 11 49 12 AM

  • JSDoc Documentation and comments have been added or updated in the code.
  • Documentation in the /docs folder has been added or updated when appropriate (no new relevant documentation)
  • Follows Nouri JavaScript guidelines
  • Commit message follows Nouri guidelines
  • Introduces minimal or no additional external packages.

What Issue number is this related to?

Closes #144
Example:

Closes #

@alex-gagnon
Copy link
Contributor

@Gregory-Pereira can you make a separate branch off this repository and make a pull request with that branch?

@alex-gagnon alex-gagnon self-requested a review February 12, 2021 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Connect with email" button in nav should be secondary

2 participants