Skip to content

Commit

Permalink
🔨 do not import fontawsome.
Browse files Browse the repository at this point in the history
  • Loading branch information
novrain committed Dec 13, 2023
1 parent 90ef26b commit aa32ad8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ Import the component or register it globally in your Vue instance:

```vue
import { LuminoBoxPanel, LuminoWidget } from "vue3-lumino-widget"
// this style include the lumino style; but lumino depends on the fontawsome for icon, it too big
// if your project already using it, it's well, if not, maybe you can replace the "X" icon by css using other font.
import 'vue3-lumino-widget/dist/style.css'
// import "@fortawesome/fontawesome-free/css/all.css"
```

Use the component in your template:
Expand Down
4 changes: 3 additions & 1 deletion docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ yarn add vue3-lumino-widget
Import the component or register it globally in your Vue instance:

```vue
import { LuminoBoxPanel, LuminoWidget } from "vue3-lumino-widget";
// this style include the lumino style; but lumino depends on the fontawsome for icon, it too big
// if your project already using it, it's well, if not, maybe you can replace the "X" icon by css using other font.
import 'vue3-lumino-widget/dist/style.css'
// import "@fortawesome/fontawesome-free/css/all.css"
```

Use the component in your template:
Expand Down
2 changes: 1 addition & 1 deletion src/components/LuminoBoxPanel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</template>

<script setup lang="ts">
import "@fortawesome/fontawesome-free/css/all.css"
// import "@fortawesome/fontawesome-free/css/all.css"
import '@lumino/default-theme/style/index.css'
import { BoxPanel, DockPanel, Widget } from '@lumino/widgets'
import { provide, onMounted, onUpdated, ref, onUnmounted } from 'vue'
Expand Down

0 comments on commit aa32ad8

Please sign in to comment.