ci(api): run novu-v2-ce e2e suite on fork PRs fixes NV-8154#11749
Merged
Conversation
Replace the legacy novu-v0 e2e suite for fork PRs with a community edition novu-v2 subset. The new test:e2e:novu-v2-ce script runs #novu-v2 tests from src/ only (excluding *.e2e-ee.ts and e2e/enterprise/) with CI_EE_TEST=false across 4 shards. Co-authored-by: Dima Grossman <dima@grossman.io>
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
Contributor
|
T-Rex pricing update — T-Rex was free through June 2026. Effective July 1, 2026, T-Rex adds 2 credits on top of the standard 1-credit review (3 total). T-Rex settings |
Add NOVU_V2_CE_ONLY / --ce-only to the existing shard script instead of maintaining a duplicate runner. CE mode limits discovery to src/**/*.e2e.ts. Co-authored-by: Dima Grossman <dima@grossman.io>
Skip files that depend on cloud-EE behavior unavailable when CI_EE_TEST=false: SSRF pinning, Stripe billing, RBAC, translations, novu-app MCP, custom environments, and org branding settings. Co-authored-by: Dima Grossman <dima@grossman.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fork PRs from community contributors cannot access the enterprise submodule, so they previously fell back to the legacy Novu V0 e2e suite. This change runs the Novu V2 CE suite instead, giving fork PRs meaningful coverage of current v2 API behavior.
Changes
test:e2e:novu-v2-cenpm script using the sharedrun-novu-v2-e2e-shard.cjsrunner withNOVU_V2_CE_ONLY=true#novu-v2tests fromsrc/only — excludes*.e2e-ee.tsande2e/enterprise/CI_EE_TEST=false(SSRF pinning, Stripe billing, RBAC, translations, novu-app MCP, custom environments, org branding settings)CI_EE_TEST=falseandCLERK_ENABLED=true(agents suite included)Excluded files (CE fork PRs)
active-conversations.e2e.tsagent-mcp-servers.e2e.tspermissions.guard.e2e.tssync.e2e.tstrigger-event-ssrf.e2e.tstest-http-endpoint.e2e.tsenvironments-v2-diff.e2e.tsapi-key-environments-exposure.e2e.tsupdate-organization-settings.e2e.ts~126 CE test files remain across 4 shards.
Flow
flowchart TD PR[PR opened] --> Fork{Fork PR?} Fork -->|Yes| CE[test:e2e:novu-v2-ce\n4 shards · CI_EE_TEST=false] Fork -->|No| EE[test:e2e:novu-v2\n4 shards · submodule · CI_EE_TEST=true]Notes
test:e2e:novu-v0script is left in place but no longer invoked by CI.start-localstack.Greptile Summary
This PR switches fork PR API E2E coverage from the legacy Novu V0 suite to Novu V2 CE. The main changes are:
test:e2e:novu-v2-cepackage script with CE-only environment flags.src/only.Confidence Score: 5/5
The workflow and shard-runner changes are targeted to CI test selection for forked API E2E runs and do not alter runtime product behavior.
The changed files are limited in scope, and the test filtering behavior is explicitly described for CE fork runs with known enterprise-only exclusions.
What T-Rex did
Reviews (3): Last reviewed commit: "ci(api): exclude EE-only tests from novu..." | Re-trigger Greptile