Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api-service): Remove forgotten console.log #7490

Merged
merged 4 commits into from
Jan 13, 2025
Merged

chore(api-service): Remove forgotten console.log #7490

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1921313
chore(api): Remove forgotten console.log
SokratisVidros Jan 13, 2025
a72a23c
fixup! chore(api): Remove forgotten console.log
SokratisVidros Jan 13, 2025
010e67b
fix(api-service): Fix for failing e2e
SokratisVidros Jan 13, 2025
640ed39
fix(api-service): Remove logging from SDK during e2e
SokratisVidros Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/reusable-api-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ jobs:
# This workflow contains a single job called "build"
e2e_api:
name: Test E2E
if: ${{ (contains(inputs.job-name, '-ee') && inputs.test-e2e-ee-affected) || (!contains(inputs.job-name, '-ee') && inputs.test-e2e-affected) }}
runs-on: ubuntu-latest
timeout-minutes: 80
permissions:
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/app/events/e2e/bulk-trigger.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describe('Trigger bulk events - /v1/events/trigger/bulk (POST) #novu-v2', functi
expect(thirdEvent.transactionId).to.equal('3333');
});

it('should gene?rate message and notification based on a bulk event', async function () {
it('should generate message and notification based on a bulk event', async function () {
await novuClient.triggerBulk({
events: [
{
Expand Down
1 change: 0 additions & 1 deletion apps/api/src/app/events/e2e/trigger-event.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,6 @@ describe('Trigger event - /v1/events/trigger (POST) #novu-v2', function () {

await session.awaitRunningJobs();
const envId = session.environment._id;
console.log(`created sub envId:${envId} subscriberId: ${subscriberId}`);
const createdSubscriber = await subscriberRepository.findBySubscriberId(envId, subscriberId);

expect(createdSubscriber?.subscriberId).to.equal(subscriberId);
Expand Down
1 change: 0 additions & 1 deletion apps/api/src/app/tenant/e2e/create-tenant.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ function assertValidationMessages(e: AxiosError<any, any>, field: string, msg1:
if (!(e instanceof AxiosError)) {
throw new Error(e);
}
console.log(JSON.stringify(e.response?.data));
const messages = e.response?.data.errors[field].messages;

expect(messages).to.be.an('array').that.includes(msg1);
Expand Down
2 changes: 0 additions & 2 deletions apps/api/src/app/topics/topics.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,6 @@ export class TopicsController {
@UserSession() user: UserSessionData,
@Query() query?: FilterTopicsRequestDto
): Promise<FilterTopicsResponseDto> {
console.log(JSON.stringify(query));

return await this.filterTopicsUseCase.execute(
FilterTopicsCommand.create({
environmentId: user.environmentId,
Expand Down
Loading