Fix entrypoint with new URL to resolve Vite build error. #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build process failed because Vite's client-side bundling analysis encountered top-level imports of Node.js built-in module 'node:path' in integration.ts. Vite externalizes these modules for browser compatibility, causing errors like "dirname is not exported by __vite-browser-external". Although the integration hook runs in Node.js, the static imports at the top level triggered this Vite behavior during the client build phase. This fix replaces the Node.js path resolution imports and functions with the standard ES Module pattern. The `URL` constructor is correctly handled by Node.js and Astro's build pipeline for integration entrypoints, avoiding the top-level import issues and allowing the build to complete successfully while maintaining portability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build process failed because Vite's client-side bundling analysis encountered top-level imports of Node.js built-in module 'node:path' in integration.ts. Vite externalizes these modules for browser compatibility, causing errors like "dirname is not exported by __vite-browser-external". Although the integration hook runs in Node.js, the static imports at the top level triggered this Vite behavior during the client build phase. This fix replaces the Node.js path resolution imports and functions with the standard ES Module pattern. The
URLconstructor is correctly handled by Node.js and Astro's build pipeline for integration entrypoints, avoiding the top-level import issues and allowing the build to complete successfully while maintaining portability.