Repository navigation
fix: accept supported Node.js prereleases at startup - #10175
Merged
Merged
Conversation
Align startup engine validation with npm-install-checks by including prereleases within the supported Node.js version bounds. Fixes #10169 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 484c16d2-f9ea-4406-b4d6-43ecd21a3341
nkolev92
approved these changes
Oct 27, 2026
Contributor
|
🎉 Backport to |
reggi
added a commit
that referenced
this pull request
Oct 30, 2026
Backport of #10175 to `release/v11`. --------- Co-authored-by: Tea Reggi <reggi@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 484c16d2-f9ea-4406-b4d6-43ecd21a3341 Copilot-Session: a0dedae4-e238-4b83-a15b-398abf209df9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
includePrerelease: truein the startup engine check, matching the existing policy innpm-install-checks. This prevents unsupported-version warnings for Node.js alphas and other prereleases within the declared engine bounds without changing the engine range.Add coverage for Node.js 27 and 28 alphas, a release candidate, and prereleases below the stable minimum or on an unsupported major.
Fixes #10169.
Validation
Both focused test files pass:
test/lib/cli/entry.jsandtest/lib/cli/validate-engines.js. The supported prerelease cases failed before the fix. ESLint on both changed files andgit diff --checkpass.