fix(arborist): Allow downgrades to hoisted version dedupe workspace i… #8168
+124
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7028
The crux of the issue as that when the downgrade was attempting to dedupe, there was nothing in the
canDedupe
logic that said it was okay to take the other version if it was an explicit request. It would see the 0.0.2 in the root, the 0.0.3 in the workspace, and give up, leaving them both as they were.The proposed change adds a new parameter
explicitRequest
to thecanDedupe
method with a default value of false. This parameter enables dedupe behavior when a package version was explicitly requested by the user.Adding the
explicitRequest
parameter introduces a new condition that allows deduping when:npm install package@version
I believe this was just an edge case that wasn't handled in the dedupe logic, and this change should fix it.