Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add load-virtual and reify tests for workspace override test coverage #8174

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

owlstronaut
Copy link
Contributor

Related: #8108

This adds test coverage for workspace override functionality

@owlstronaut owlstronaut force-pushed the owlstronaut/workspace-override-tests branch 6 times, most recently from 3fe6298 to b097174 Compare March 20, 2025 23:09
@owlstronaut owlstronaut force-pushed the owlstronaut/workspace-override-tests branch from b097174 to 8f2bd94 Compare March 20, 2025 23:13
@owlstronaut
Copy link
Contributor Author

Well I learned about this today, that's annoying. Have to enable it on my platform to update the snapshot, then re-disable it for ci 😭

  // This test flakes out on Apple Silicon
  // https://github.com/npm/cli/pull/7411
  process.platform === 'darwin' && process.arch === 'arm64'
    ? null
    : 'selflink',

@owlstronaut owlstronaut marked this pull request as ready for review March 20, 2025 23:18
@owlstronaut owlstronaut requested a review from a team as a code owner March 20, 2025 23:18
@owlstronaut owlstronaut merged commit 88a7b52 into latest Mar 25, 2025
16 checks passed
@owlstronaut owlstronaut deleted the owlstronaut/workspace-override-tests branch March 25, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants