Skip to content
This repository has been archived by the owner on Jul 28, 2021. It is now read-only.

[UNFINISHED] Use ts-node to register on-the-fly TS support #45

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from
Open

[UNFINISHED] Use ts-node to register on-the-fly TS support #45

wants to merge 1 commit into from

Conversation

wavebeem
Copy link

@wavebeem wavebeem commented Jan 20, 2019

This is not done seeing as there's a decision to make about when to enable type checking. Should it use a command line flag? Environment variable? Both? Some kind of complex series of checks to Do the Right Thing™?

The core of this change is just adding in ts-node since they do a fantastic job of making all this work, and there's no reason to replicate the ~500 lines of code they have.

Note that new tink projects will need to install @types/node or ts-node and have a simple tsconfig.json if they intend to use JSX"

{
  "compilerOptions": {
    "jsx": "react"
  }
}

There's also still the issue of typescript expecting to traverse node modules to find type definitions, so those will have to be fetched manually for now, I guess?

Also a random note but tink sh is giving me a stack overflow on Windows (!).

Another thing, right now it seems that tink shows the usage screen whenever an exception is thrown. This means that type errors are accompanied by like 10 lines of help on screen which are very distracting. Something needs to be done about that for this case, in my opinion.

@wavebeem
Copy link
Author

No pressure, just figured I'd check and see if you've had time to look at this and have any concerns or questions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant