This repository has been archived by the owner on Jul 28, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I did run tink in a project folder without package-lock.json, it resulted in an infinite loop.
After digging around, I found where the problem was (and this is what this PR fixes).
Please read the commit description if you need some context about the modifications.
Before this PR
package-lock.json
After this PR
package-lock.json
./src/index.js
➜ project git:(master) ✗ tink -l silly sh ./src/index.js tink verb prepare checking package-lock is up to date. tink verb prepare Fetching and installing dependencies. tink info prepare initializing installer tink verb prepare installation prefix: /Volumes/sensitive/work/tink-pnp/demo/project tink verb checkLock verifying package-lock data tink verb teardown shutting down tink info teardown Done in 0.001s [...]
Have a nice weekend,