fix: change outdated deps indicator#2883
Conversation
`lucide:circle-alert` is too serious, users may think it means security vulnerabilities. Changed to `lucide:circle-fading-arrow-up`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe outdated dependency status indicator in the Dependencies component was changed from a circle-alert glyph to an arrow-up glyph. No component logic or dependency handling was modified. ChangesDependencies Icon Update
Possibly related issues
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello! Thank you for opening your first PR to npmx, @typed-sigterm! 🚀 Here’s what will happen next:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Also, outdated deps should not be red. It's a harmless option of maintainers, unlike security vulnerabilities. |
gameroman
left a comment
There was a problem hiding this comment.
Could you add before-after screenshots, please
|
Added in description |
|
I made several mock-ups trying various options especially: |
|
I agree that the current icons and colours might be misleading. When the feature was released I was a little confused myself. I really like the icon you chose, I think the simple arrow is a too... well simple. But I agree we probably want more opinions on this. |
|
Perhaps it's also unnecessary to set error colors on deps with newer major versions |
|
I'd go with what Matteo suggested, but would leave the colouring for a separate PR. though my opinion on that is that we should still colour majors vs minors differently, maybe just not red if people are concerned about that being too strong of a signal |
|
I actually like the triangle too |
|
Let's vote at #2930 and wait for 7 days :) It'll be great if anyone would like to post this in the Discord maintainers channel. |
|
Fwiw, I think a triangle is too abstract because you have to learn its meaning before you can read it, while you can arguably intuit the meaning of an up-arrow. |
I'm not sure I can connect "outdated" with an upward arrow. A triangle is a common warning symbol, and it is designed to get your attention. |
|
Looks like the arrow is the most supported one. Lets do that then |
Co-authored-by: Roman <dev@rman.dev>
gameroman
left a comment
There was a problem hiding this comment.
Good 👍
Also update the PR description with new icons, please




🔗 Linked issue
N/A for tiny fix.
🧭 Context
lucide:circle-alertis too serious, users may think it means security vulnerabilities.📚 Description
Change icon to
lucide:circle-fading-arrow-up.Before:

After:
