Skip to content

fix: change outdated deps indicator#2883

Open
typed-sigterm wants to merge 2 commits into
npmx-dev:mainfrom
typed-sigterm:main
Open

fix: change outdated deps indicator#2883
typed-sigterm wants to merge 2 commits into
npmx-dev:mainfrom
typed-sigterm:main

Conversation

@typed-sigterm

@typed-sigterm typed-sigterm commented Jun 9, 2026

Copy link
Copy Markdown

🔗 Linked issue

N/A for tiny fix.

🧭 Context

lucide:circle-alert is too serious, users may think it means security vulnerabilities.

📚 Description

Change icon to lucide:circle-fading-arrow-up.

Before:
image

After:
image

`lucide:circle-alert` is too serious, users may think it means security vulnerabilities. Changed to `lucide:circle-fading-arrow-up`.
@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 15, 2026 11:36am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 15, 2026 11:36am
npmx-lunaria Ignored Ignored Jul 15, 2026 11:36am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0f2299e6-1214-4355-acdc-b941f69961d9

📥 Commits

Reviewing files that changed from the base of the PR and between 90412cc and e8fd59b.

📒 Files selected for processing (1)
  • app/components/Package/Dependencies.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/components/Package/Dependencies.vue

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Updated the outdated-dependency indicator to use a clearer upward-arrow icon.

Walkthrough

The outdated dependency status indicator in the Dependencies component was changed from a circle-alert glyph to an arrow-up glyph. No component logic or dependency handling was modified.

Changes

Dependencies Icon Update

Layer / File(s) Summary
Outdated dependency indicator icon
app/components/Package/Dependencies.vue
The icon glyph for outdated dependencies was changed from i-lucide:circle-alert to i-lucide:arrow-up.

Possibly related issues

  • npmx-dev/npmx.dev#2275 — Concerns replacing alarming outdated-dependency warning markers with a less warning-oriented icon.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: updating the outdated dependencies indicator icon.
Description check ✅ Passed The description is directly related to the icon change and explains the motivation and visual update.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @typed-sigterm! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@typed-sigterm

Copy link
Copy Markdown
Author

Also, outdated deps should not be red. It's a harmless option of maintainers, unlike security vulnerabilities.

@gameroman gameroman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add before-after screenshots, please

@typed-sigterm

Copy link
Copy Markdown
Author

Added in description

@typed-sigterm
typed-sigterm requested a review from gameroman June 16, 2026 09:35
@gameroman

Copy link
Copy Markdown
Member
image

I like this, but I think it looks a bit unreadable at small size?

Do you think we could do the arrow without circle? Or maybe you have some other better ideas

Maybe clock-arrow-up or circle-plus?

I want to know what others think too

@gameroman gameroman added the needs review This PR is waiting for a review from a maintainer label Jun 16, 2026
@gameroman
gameroman requested a review from a team June 16, 2026 13:24
@gameroman gameroman added the front Frontend, Design label Jun 16, 2026
@alfonsusac

Copy link
Copy Markdown
Contributor

I made several mock-ups trying various options especially: clock-arrow-up and square-arrow-up. We've discussed this in Discord and decided that arrow-up fits well. We avoided border to not make it similar to an "alert" badge (the one with shield and checkmark) and it also has easily distinguishable overall shape (arrow).

Mock-up for arrow-up
image

@trueberryless

trueberryless commented Jun 16, 2026

Copy link
Copy Markdown
Member

I agree that the current icons and colours might be misleading. When the feature was released I was a little confused myself.

I really like the icon you chose, I think the simple arrow is a too... well simple. But I agree we probably want more opinions on this.

@trueberryless trueberryless added the needs discussion An idea that needs more discussion to understand the scope and impact. label Jun 16, 2026
@MatteoGabriele

Copy link
Copy Markdown
Member

My 2 cents: I think the best one would be "i-lucide:history", but this icon renders way too small for all those details, so if we want something that brings attention without overwhelming, I think a simple "i-lucide:triangle" could just work.

Screenshot 2026-06-16 at 22 46 36

@typed-sigterm

Copy link
Copy Markdown
Author

Perhaps it's also unnecessary to set error colors on deps with newer major versions

@43081j

43081j commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I'd go with what Matteo suggested, but would leave the colouring for a separate PR.

though my opinion on that is that we should still colour majors vs minors differently, maybe just not red if people are concerned about that being too strong of a signal

@trueberryless

trueberryless commented Jun 17, 2026

Copy link
Copy Markdown
Member

Looks like a simple arrow up the winner of our little discussion on Discord:

Screenshot_20260617-134843.png

Now we have to decide: Discord vs GitHub 😆

@trueberryless trueberryless added needs discussion An idea that needs more discussion to understand the scope and impact. and removed needs discussion An idea that needs more discussion to understand the scope and impact. labels Jun 17, 2026
@gameroman

Copy link
Copy Markdown
Member

I actually like the triangle too

@typed-sigterm

Copy link
Copy Markdown
Author

Let's vote at #2930 and wait for 7 days :) It'll be great if anyone would like to post this in the Discord maintainers channel.

@mootari

mootari commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Fwiw, I think a triangle is too abstract because you have to learn its meaning before you can read it, while you can arguably intuit the meaning of an up-arrow.

@MatteoGabriele

Copy link
Copy Markdown
Member

Fwiw, I think a triangle is too abstract because you have to learn its meaning before you can read it, while you can arguably intuit the meaning of an up-arrow.

I'm not sure I can connect "outdated" with an upward arrow. A triangle is a common warning symbol, and it is designed to get your attention.

@gameroman

Copy link
Copy Markdown
Member

Looks like the arrow is the most supported one. Lets do that then

Comment thread app/components/Package/Dependencies.vue Outdated
@gameroman gameroman removed needs discussion An idea that needs more discussion to understand the scope and impact. needs review This PR is waiting for a review from a maintainer labels Jul 12, 2026
Co-authored-by: Roman <dev@rman.dev>

@gameroman gameroman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

Also update the PR description with new icons, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front Frontend, Design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants