Skip to content

fix(i18n): make missing strings translatable#3065

Open
igorskyflyer wants to merge 2 commits into
npmx-dev:mainfrom
igorskyflyer:missing-strings
Open

fix(i18n): make missing strings translatable#3065
igorskyflyer wants to merge 2 commits into
npmx-dev:mainfrom
igorskyflyer:missing-strings

Conversation

@igorskyflyer

@igorskyflyer igorskyflyer commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

#3064

🧭 Context

When a Noodle is missing, a non-translated (English) string is shown for all languages (tested on locales: ES, RU), i.e.

<p class="font-mono text-xs tracking-widest uppercase text-fg-subtle mb-3">
  404 — empty bowl
</p>

📚 Description

This PR:

  • makes the string for a missing noodle translatable in the source code (app/pages/noodles/[slug].vue)
  • adds the key to the i18n/locales/en.json
  • updates the i18n/schema.json

There might be more strings, I'll keep checking.

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 20, 2026 7:34pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 20, 2026 7:34pm
npmx-lunaria Ignored Ignored Jul 20, 2026 7:34pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The missing-noodle 404 message now uses an i18n key. The English locale defines the new empty_bowl translation, and the i18n schema requires it.

Changes

Missing-noodle localisation

Layer / File(s) Summary
Translation contract and fallback usage
i18n/locales/en.json, i18n/schema.json, app/pages/noodles/[slug].vue
Adds the noodles.missing.empty_bowl English translation and schema property, then uses the key in the 404 fallback while retaining the 404 — prefix.

Suggested reviewers: adebesin-cell

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed It concisely describes the main change: making the missing-noodle strings translatable.
Description check ✅ Passed It directly describes the i18n changes made to the page, locale file, and schema.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant