fix(i18n): make missing strings translatable#3065
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe missing-noodle 404 message now uses an i18n key. The English locale defines the new ChangesMissing-noodle localisation
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
#3064
🧭 Context
When a Noodle is missing, a non-translated (English) string is shown for all languages (tested on locales: ES, RU), i.e.
📚 Description
This PR:
app/pages/noodles/[slug].vue)i18n/locales/en.jsoni18n/schema.jsonThere might be more strings, I'll keep checking.