chore: add searchProviderValue to useSearchProvider - #3134
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change centralises search provider resolution in ChangesSearch provider resolution
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/composables/useGlobalSearch.ts`:
- Line 11: Update the URL query setter and both flushUpdateUrlQuery calls in
useGlobalSearch to pass the resolved searchProviderValue.value instead of
searchProvider.value, preserving route query overrides such as p='npm'. Add a
regression test covering an npm route override when the saved provider is
algolia.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 00211f7d-3fd0-4ee7-ad22-8d41a94d4806
📒 Files selected for processing (5)
app/components/SearchProviderToggle.client.vueapp/composables/npm/useOrgPackages.tsapp/composables/npm/useUserPackages.tsapp/composables/useGlobalSearch.tsapp/composables/useSettings.ts
🔗 Linked issue
None
🧭 Context
📚 Description
Simplify
searchProviderValuehandling