Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build application in sdk-nrf-toolchain docker image #13

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

jangalda-nsc
Copy link
Contributor

No description provided.

Copy link

@karhama karhama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two issues also exists in build.yml

.github/workflows/build-ncs.yml Outdated Show resolved Hide resolved
container: ghcr.io/nrfconnect/sdk-nrf-toolchain:v2.6.0
steps:
- name: Checkout repository with example application
uses: actions/checkout@v3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some nag about nodejs. using checkout@v4 might help.

@jangalda-nsc jangalda-nsc merged commit 402c145 into main Mar 28, 2024
9 checks passed
@jangalda-nsc jangalda-nsc deleted the build-in-ncs-docker branch March 28, 2024 10:28
@gmarull
Copy link
Member

gmarull commented Apr 11, 2024

Please, do not merge without further approvals. This was merged without commits following a proper structure, nor reviewed with the maintainers of this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants