Allow building NCS BM samples without SW ISR table #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
manifest
changelog-entry-required
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
You can find the documentation preview for this PR here. |
There was a problem hiding this comment.
@bjarki-andreasen Please see build issues and rebase on main to update defconfig for SoftDevice S145 board variants.
lib/bm_buttons/bm_buttons.c
Outdated
| #endif | ||
| } | ||
|
|
||
| #if defined(CONFIG_SOC_SERIES_NRF52X) |
There was a problem hiding this comment.
All nRF52 related code can be removed, this was used for early development but will be removed.
bjarki-andreasen
force-pushed
the
no-sw-isr-table
branch
from
db157bd to
7572386
Compare
boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l05_cpuapp_s115_softdevice_defconfig
Show resolved
Hide resolved
|
Please add changelog entry. Otherwise LGTM when manifest is updated and comment above is addressed. |
bjarki-andreasen
force-pushed
the
no-sw-isr-table
branch
from
7572386 to
c0c5d5d
Compare
github-actions
bot
added
doc-required
bjarki-andreasen
force-pushed
the
no-sw-isr-table
branch
2 times, most recently
from
afb9d42 to
03ad563
Compare
b-gent
added
the
doc-postponed
b-gent
approved these changes
Oct 29, 2025
anhmolt
approved these changes
Oct 31, 2025
update sdk-nrf to a7e36dcbea5d835baea5e96ea80d0b7955e296fd Signed-off-by: Bjarki Arge Andreasen <[email protected]>
The software ISR table is not required if multithreading is not used, and no argument is passed to the irq handlers. Update all drivers, samples and subsystems to not use the SW ISR table and exclude it from the build. This saves approximately 2K ROM for all builds. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Mention change from IRQ_CONNECT to IRQ_DIRECT_CONNECT, describing why the change was made and how an application must adapt to it. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
no-sw-isr-table
branch
from
03ad563 to
86d8f03
Compare
|
ping @nrfconnect/ncs-eris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow building NCS BM samples without SW ISR table