-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast Pair callback API improvements #19737
Conversation
Relaxed the context assumptions in the bt_fast_pair_info_cb_register API to allow calling this API during the system initialization. Ref: NCSDK-30487 Signed-off-by: Kamil Piszczek <[email protected]>
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 156c81fd3a5d9940602042b61d4785367a587f36 more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention at the top of the file (line 17) that some functions can be called from sys_init. We have there a comment that It is required to use the Fast Pair FMDN API in the cooperative thread context (for example, system workqueue thread).
, which is no longer true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could e.g. state that * It is required to use most of the the Fast Pair FMDN APIs in the cooperative thread context
? (to avoid going into details)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improved this inconsistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could e.g. state that * It is required to use most of the the Fast Pair FMDN APIs in the cooperative thread context
? (to avoid going into details)
Improved the documentation for the callback registrations APIs in the Fast Pair FMDN header. Ref: NCSDK-30487 Signed-off-by: Kamil Piszczek <[email protected]>
018328c
to
156c81f
Compare
No description provided.