Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast Pair callback API improvements #19737

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Jan 3, 2025

No description provided.

Relaxed the context assumptions in the bt_fast_pair_info_cb_register
API to allow calling this API during the system initialization.

Ref: NCSDK-30487

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no kapi-no requested a review from a team as a code owner January 3, 2025 10:26
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 3, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 3, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 156c81fd3a5d9940602042b61d4785367a587f36

more details

sdk-nrf:

PR head: 156c81fd3a5d9940602042b61d4785367a587f36
merge base: 1536c9082ff9e6a2105ddc2b85a8c0928c8e458a
target head (main): 727987430324d171d6b3f075a2813fae01116013
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
include
│  ├── bluetooth
│  │  ├── services
│  │  │  ├── fast_pair
│  │  │  │  ├── fast_pair.h
│  │  │  │  │ fmdn.h
subsys
│  ├── bluetooth
│  │  ├── services
│  │  │  ├── fast_pair
│  │  │  │  │ fp_gatt_service.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 856
  • ✅ Integration tests
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my
Disabled integration tests
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@kapi-no kapi-no changed the title Fast Pair callback API improvemnts Fast Pair callback API improvements Jan 3, 2025
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention at the top of the file (line 17) that some functions can be called from sys_init. We have there a comment that It is required to use the Fast Pair FMDN API in the cooperative thread context (for example, system workqueue thread)., which is no longer true.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could e.g. state that * It is required to use most of the the Fast Pair FMDN APIs in the cooperative thread context? (to avoid going into details)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improved this inconsistency

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could e.g. state that * It is required to use most of the the Fast Pair FMDN APIs in the cooperative thread context? (to avoid going into details)

Improved the documentation for the callback registrations APIs in the
Fast Pair FMDN header.

Ref: NCSDK-30487

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no kapi-no force-pushed the fast_pair_cb_api_improvemnts branch from 018328c to 156c81f Compare January 7, 2025 13:46
@kapi-no kapi-no removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 8, 2025
@kapi-no kapi-no merged commit 0825ffb into nrfconnect:main Jan 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants