[nrf fromlist] modules: hal_nordic: align to BSP outside of nrfx #3342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magp-nordic
force-pushed
the
NRFX-8370-new-bsps-outside-of-hal-nordic
branch
from
b4a4c24 to
7982f5d
Compare
masz-nordic
reviewed
Oct 13, 2025
Comment on lines
+33
to
+37
| zephyr_compile_definitions(NRFX_BSP_NRF_PATH="mdk/nrf.h") | ||
| zephyr_compile_definitions(NRFX_BSP_ERRATAS_PATH="mdk/nrf_erratas.h") | ||
| zephyr_compile_definitions(NRFX_BSP_SOC_IRQS_PATH="soc/nrfx_irqs.h") | ||
| zephyr_compile_definitions(NRFX_BSP_NRFX_EXT_PATH="nrfx_ext.h") | ||
| zephyr_compile_definitions(NRFX_BSP_NRFX_COREDEP_PATH="soc/nrfx_coredep_defs.h") |
There was a problem hiding this comment.
This implicitly removes need for those compile definitions in BSP dispatcher.
Is that by design?
There was a problem hiding this comment.
@masz-nordic yes, it is. Chosen BSP dir is added to include path anyway above, and paths containing BSP are no longer valid since they can be placed anywhere in NCS, even in directories that are not in include path (for example, when I tested it with #3336 I set the BSP external path to modules/hal/bspexternal and building failed on those lines before I removed CONFIG_SOC_NORDIC_BSP_NAME).
There was a problem hiding this comment.
Then a PR removing compile definitions usage in nrfx should be created too.
Align sdk-zephyr to having external BSP outside of nrfx directory. Upstream PR #: 96842 Signed-off-by: Magdalena Pastula <[email protected]>
magp-nordic
force-pushed
the
NRFX-8370-new-bsps-outside-of-hal-nordic
branch
from
7982f5d to
f290871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align sdk-zephyr to having external BSP outside of nrfx directory.
Upstream PR #: 96842