This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizter
force-pushed
the
feat/playwright-test-migration
branch
from
July 19, 2023 11:17
3394d0a
to
7fe2421
Compare
klizter
changed the title
[WIP] feat: playwright test migration
feat: playwright test migration
Aug 11, 2023
klizter
commented
Aug 31, 2023
klizter
commented
Aug 31, 2023
{ | ||
name: 'webkit', | ||
use: { ...devices['Desktop Safari'] } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add browsers:
- Microsoft Edge
- IE (?)
klizter
commented
Aug 31, 2023
klizter
commented
Aug 31, 2023
Seven tests are presently skipped, and look to be annotated with Running 333 tests using 4 workers
7 skipped
326 passed (41.4s) Should either be fixed or pruned as deemed appropriate |
klizter
force-pushed
the
feat/playwright-test-migration
branch
from
September 4, 2023 12:11
eff6ca5
to
7b4c371
Compare
skjalgepalg
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a pretty solid foundation for now. Further tweaks can be moved to separate issues so we don't drag the scope of this issue out indefinitely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from protractor to playwright.
Migration progress: