Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

feat: playwright test migration #717

Merged
merged 59 commits into from
Sep 5, 2023
Merged

Conversation

klizter
Copy link
Contributor

@klizter klizter commented Jul 17, 2023

Moving from protractor to playwright.

Migration progress:

  • core-datepicker
  • core-dialog
  • core-progress
  • core-scroll
  • core-suggest
  • core-tabs
  • core-toggle

@klizter klizter force-pushed the feat/playwright-test-migration branch from 3394d0a to 7fe2421 Compare July 19, 2023 11:17
@klizter klizter marked this pull request as draft August 11, 2023 10:30
@klizter klizter changed the title [WIP] feat: playwright test migration feat: playwright test migration Aug 11, 2023
playwright.config.ts Outdated Show resolved Hide resolved
{
name: 'webkit',
use: { ...devices['Desktop Safari'] }
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add browsers:

  1. Microsoft Edge
  2. IE (?)

package.json Outdated Show resolved Hide resolved
jsconfig.json Show resolved Hide resolved
@skjalgepalg
Copy link
Collaborator

Seven tests are presently skipped, and look to be annotated with FIXME:

Running 333 tests using 4 workers
  7 skipped
  326 passed (41.4s)

Should either be fixed or pruned as deemed appropriate

@klizter klizter force-pushed the feat/playwright-test-migration branch from eff6ca5 to 7b4c371 Compare September 4, 2023 12:11
Copy link
Collaborator

@skjalgepalg skjalgepalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a pretty solid foundation for now. Further tweaks can be moved to separate issues so we don't drag the scope of this issue out indefinitely.

@skjalgepalg skjalgepalg merged commit 523c845 into master Sep 5, 2023
1 check passed
@skjalgepalg skjalgepalg deleted the feat/playwright-test-migration branch September 5, 2023 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants